Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly wrong big data serialization #106

Open
Affie opened this issue Mar 6, 2019 · 4 comments
Open

Possibly wrong big data serialization #106

Affie opened this issue Mar 6, 2019 · 4 comments
Assignees
Labels
API change bug Something isn't working

Comments

@Affie
Copy link
Contributor

Affie commented Mar 6, 2019

The .data Array{Uint8,1} returned has a bunch of 0x00 at the end causing the JSON string in it to be miss-formed. It seems to work with similar code on a small piece of data.

@GearsAD GearsAD self-assigned this Mar 11, 2019
@GearsAD
Copy link
Owner

GearsAD commented Mar 11, 2019

WIP, more to follow on Wednesday

@GearsAD GearsAD added bug Something isn't working API change labels Mar 11, 2019
@GearsAD
Copy link
Owner

GearsAD commented Mar 17, 2019

Okay, this we have this figured out. Its actually two bugs:

  • Our gateway was doing strange encoding on the binary data. Thats why we could only see it on the running cloud server. That explains why it was larger. Ive changed the SDK to work with strings and it base64 encodes binary data when you use the helper encodeBinaryData.
  • In addition, our server-side stream reader was truncating the data if it was large. Subequently changed out and im redeploying it tonight. That explains why we saw the ends of the files as zeros and only saw it with data > a couple kb

So, two changes made. @Affie you may need to switch back to strings for data. But otherwise should be ok.

@GearsAD
Copy link
Owner

GearsAD commented Mar 17, 2019

#108

@GearsAD
Copy link
Owner

GearsAD commented Mar 18, 2019

Can we confirm that all is ok?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API change bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants