Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make some protected methods public #635

Closed
1 task done
shawfactor opened this issue Apr 1, 2024 · 2 comments · Fixed by #878
Closed
1 task done

Make some protected methods public #635

shawfactor opened this issue Apr 1, 2024 · 2 comments · Fixed by #878
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@shawfactor
Copy link

Is your enhancement related to a problem? Please describe.

ATM the get_formatted_datetime and get_calendar_description methods within the event class are protected. Is there a good reason for this. I ask as I was building my own plugin based on yours and needed them but they are protected. AFAICT there are no aternatives to this for getting local datetimes or descriptions that devs can utlise and I cannot see a security implication.

Can this be fixed?

Designs

No response

Describe alternatives you've considered

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@shawfactor shawfactor added the enhancement New feature or request label Apr 1, 2024
@shawfactor
Copy link
Author

shawfactor commented Jun 27, 2024

following up on this, although I think this needs to be broader. There needs to be a review of all methods in this plugin. There are many protected methods that should be public e.g. get_formatted_datetime and many public methods that should be public static e.g. get_venue_post_from_term_slug

The underlying point being people will want to build functionality on top of this plugin (I am doing this atm) and if it is safe useful methods should be accessible to people who want to build functionality

@mauteri
Copy link
Contributor

mauteri commented Aug 7, 2024

@shawfactor This seems reasonable. I'm unsure why some of those methods are protected. Thanks for flagging this and feel free if you like to put in a pull request to change some methods you need made public. We're always looking for new contributors. :-) If you'd rather not put in a PR, that's fine too. I can flag this for 0.31.0 since 0.30.0 is pretty much done and being tested at the moment.

@mauteri mauteri moved this to Following Release in GatherPress Project Aug 7, 2024
@mauteri mauteri added this to the 0.31.0 milestone Aug 7, 2024
@mauteri mauteri added the good first issue Good for newcomers label Aug 16, 2024
@mauteri mauteri self-assigned this Aug 16, 2024
@github-project-automation github-project-automation bot moved this from Next Release to Done in GatherPress Project Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Development

Successfully merging a pull request may close this issue.

2 participants