Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INVALID_DRILL_UP rule providing #77

Closed
buchslava opened this issue May 5, 2016 · 0 comments
Closed

INVALID_DRILL_UP rule providing #77

buchslava opened this issue May 5, 2016 · 0 comments

Comments

@buchslava
Copy link
Collaborator

buchslava commented May 5, 2016

  • Rule name: Should be filled if this issue depends on particular rule especially during new rule creation. This name should be a valid JS variable name and should be used for connecting with code.

INVALID_DRILL_UP

  • Rule test folder: Should be filled if type of Request is rule. Needed for documentation auto generation.

test/fixtures/rules-cases/invalid-drill_up

  • Rule description: Should be filled if type of Request is rule. Needed for documentation auto generation.

An issue according to this rule will be fired when drillup in concept is defined and not valid: not a set of valid concepts

  • Examples of correct data:

ddf--concepts.csv

concept,concept_type,domain,name,drill_up
name,string,,
geo,entity_domain,,
region,entity_set,geo,Region
country,entity_set,geo,Country,['geographic_regions', 'income_groups', 'landlocked', 'g77_and_oecd_countries', 'geographic_regions_in_4_colors', 'main_religion_2008']
capital,entity_set,geo,Capital
pop,measure,geo,Population
year,time,,year
  • Examples of incorrect data:

ddf--concepts.csv

concept,concept_type,domain,name,drill_up
name,string,,
geo,entity_domain,,
region,entity_set,geo,Region
country,entity_set,geo,Country,['foo', 'main_religion_2008']
capital,entity_set,geo,Capital,foo
pop,measure,geo,Population
year,time,,year
  • Scenarios Should be filled if type of Request is rule.
when dataset is correct
  any issue should NOT be found for this rule
when dataset is NOT correct
  issues in accordance with wrong concept drillups quantity should be detected for this rule
  output data for any issue should be expected
  • Output data format Additional data that depends on particular issue type. Should be filled if type of Request is rule.

wrong drillup value

@buchslava buchslava added this to the ddf1 milestone May 5, 2016
@buchslava buchslava changed the title CONCEPT_INVALID_DRILLUP rule providing INVALID_CONCEPT_DRILLUP rule providing May 5, 2016
@buchslava buchslava changed the title INVALID_CONCEPT_DRILLUP rule providing INVALID_DRILLUP rule providing Jun 13, 2016
@buchslava buchslava changed the title INVALID_DRILLUP rule providing INVALID_DRILL_UP rule providing Jun 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant