muxHandle is wrong

[langston-barrett]

Crucible doesn't really support muxing function handles, but it does have this muxHandle operation:

crucible/crucible/src/Lang/Crucible/Simulator/RegValue.hs

Lines 269 to 277 in 3ed848a

	muxHandle :: IsExpr (SymExpr sym)
	=> sym
	-> Pred sym
	-> FnVal sym a r
	-> FnVal sym a r
	-> IO (FnVal sym a r)
	muxHandle _ c x y
	| Just b <- asConstantPred c = pure $! if b then x else y
	| otherwise = return x

This is plainly wrong, as it just returns the first FnVal in the case that the predicate isn't statically known. It should probably panic instead. This code is also reachable via this CanMux instance:

crucible/crucible/src/Lang/Crucible/Simulator/RegValue.hs

Lines 279 to 282 in 3ed848a

	instance IsExprBuilder sym => CanMux sym (FunctionHandleType a r) where
	{-# INLINE muxReg #-}
	muxReg s = \_ c x y -> do
	muxHandle s c x y

Both of these are exported.

I'd advocate for:

• Making a tryMuxHandle function that returns a Maybe
• Changing muxHandle to call tryMuxHandle and panic on Nothing
• Removing the CanMux instance, because it is likely to lead to surprises

However, all of these except the first are breaking changes.