Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lightbox toggles class "iframe" when showing just images #319

Open
sammik opened this issue Jan 31, 2014 · 1 comment · May be fixed by #420
Open

lightbox toggles class "iframe" when showing just images #319

sammik opened this issue Jan 31, 2014 · 1 comment · May be fixed by #420

Comments

@sammik
Copy link

sammik commented Jan 31, 2014

If using images, then data.iframe is undefined. Therefore lightbox.image.isIframe = ( data.iframe && !data.image ); is also undefined, so toggleClass switch doesn't work https://github.com/aino/galleria/blob/master/src/galleria.js#L2387
using !!data.iframe instead of data.iframe could fix it.
lightbox.image.isIframe = ( !!data.iframe && !data.image );
https://github.com/aino/galleria/blob/master/src/galleria.js#L2385

@b2point0h
Copy link

Having same issue here. It creates a huge area for the left/right side arrow holders which if user is trying to click the close button, it just moves forward to the next image.

@sammik sammik linked a pull request Apr 15, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants