Layouts should restore window size, position and current tab

[bentoogood]

Layouts should restore

• window size
• position
• current tab

[thiasbxl]

If we ever save the layout with the scene (Issue #50) we should also save what node is pinned to what tab/panel

[bentoogood]

This should be covered already by #493
If you save a layout it saves the pinned status.

[johnhaddon]

It does need mentioning actually - whether an editor is pinned or not does differ from which node is in it, and the latter isn't currently saved anywhere. Do we have a ticket for "save layout in script"? - if so this discussion would be best on there.

[bentoogood]

Ah - I read Matias's comment incorrectly. I thought the request was just for pin or no pin.

Do we have a ticket for "save layout in script"? - if so this discussion would be best on there.

#50 - referenced above, so these two should be linked now.

[johnhaddon]

Quick note to say that when we restore the window size and position, we need to take care that this works sensibly when opening on a lower res monitor, or going from a dual monitor to single monitor setup...

[andrewkaufman]

Is this issue going to be resolved by @themissingcow's current tasks (#34, #50, #3139)? Or will the "pinned status" be the one outstanding remaining issue here?

[johnhaddon]

Depends what is meant by "pinned status". We already save a boolean for whether an editor was pinned or not, but saving pinned status doesn't really make sense unless the layout is saved with the script and we also save which nodes were pinned in. I'm not sure that's something I want anyway, I like that when you load something it doesn't immediately start computing whatever happened to be pinned last time you saved. That's kindof the whole point of deferred loading.

I think we should close this ticket when Tom's done with his current tasks, and reconsider pinning as part of the ticket for saving layouts with scripts (which is another thing I'm not particularly keen on).

[andrewkaufman]

Depends what is meant by "pinned status".... saving pinned status [requires that] the layout is saved with the script and we also save which nodes were pinned in

Yes, that is the particular request in question. I was trying to determine if this Issue maps to an internal IE ticket or not.

I think we should close this ticket when Tom's done with his current tasks and reconsider pinning as part of the ticket for saving layouts with scripts (which is another thing I'm not particularly keen on).

Ok, well that is #50, which is one of Tom's current tasks... or at least its on the Up Next board and assigned to Tom. In any case, I'm fine to do that, close this one and make saving which node is pinned (or deciding thats bad) part of #50

[johnhaddon]

OK, closing.