Skip to content

Commit 00baec5

Browse files
committed
[minor](log) Delete useless logics checking (apache#41589)
1 parent 8cf24d0 commit 00baec5

File tree

2 files changed

+2
-18
lines changed

2 files changed

+2
-18
lines changed

be/src/pipeline/pipeline_x/local_exchange/local_exchange_sink_operator.cpp

+2-16
Original file line numberDiff line numberDiff line change
@@ -52,28 +52,16 @@ Status LocalExchangeSinkLocalState::open(RuntimeState* state) {
5252
return Status::OK();
5353
}
5454

55-
Status LocalExchangeSinkLocalState::close(RuntimeState* state, Status exec_status) {
56-
if (_closed) {
57-
return Status::OK();
58-
}
59-
RETURN_IF_ERROR(Base::close(state, exec_status));
60-
if (exec_status.ok()) {
61-
DCHECK(_release_count) << "Do not finish correctly! " << debug_string(0);
62-
}
63-
return Status::OK();
64-
}
65-
6655
std::string LocalExchangeSinkLocalState::debug_string(int indentation_level) const {
6756
fmt::memory_buffer debug_string_buffer;
6857
fmt::format_to(debug_string_buffer,
6958
"{}, _use_global_shuffle: {}, _channel_id: {}, _num_partitions: {}, "
7059
"_num_senders: {}, _num_sources: {}, "
71-
"_running_sink_operators: {}, _running_source_operators: {}, _release_count: {}",
60+
"_running_sink_operators: {}, _running_source_operators: {}",
7261
Base::debug_string(indentation_level),
7362
_parent->cast<LocalExchangeSinkOperatorX>()._use_global_shuffle, _channel_id,
7463
_exchanger->_num_partitions, _exchanger->_num_senders, _exchanger->_num_sources,
75-
_exchanger->_running_sink_operators, _exchanger->_running_source_operators,
76-
_release_count);
64+
_exchanger->_running_sink_operators, _exchanger->_running_source_operators);
7765
return fmt::to_string(debug_string_buffer);
7866
}
7967

@@ -121,13 +109,11 @@ Status LocalExchangeSinkOperatorX::sink(RuntimeState* state, vectorized::Block*
121109

122110
// If all exchange sources ended due to limit reached, current task should also finish
123111
if (local_state._exchanger->_running_source_operators == 0) {
124-
local_state._release_count = true;
125112
local_state._shared_state->sub_running_sink_operators();
126113
return Status::EndOfFile("receiver eof");
127114
}
128115
if (eos) {
129116
local_state._shared_state->sub_running_sink_operators();
130-
local_state._release_count = true;
131117
}
132118

133119
return Status::OK();

be/src/pipeline/pipeline_x/local_exchange/local_exchange_sink_operator.h

-2
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ class LocalExchangeSinkLocalState final : public PipelineXSinkLocalState<LocalEx
3838

3939
Status init(RuntimeState* state, LocalSinkStateInfo& info) override;
4040
Status open(RuntimeState* state) override;
41-
Status close(RuntimeState* state, Status exec_status) override;
4241
std::string debug_string(int indentation_level) const override;
4342

4443
private:
@@ -62,7 +61,6 @@ class LocalExchangeSinkLocalState final : public PipelineXSinkLocalState<LocalEx
6261

6362
// Used by random passthrough exchanger
6463
int _channel_id = 0;
65-
bool _release_count = false;
6664
};
6765

6866
// A single 32-bit division on a recent x64 processor has a throughput of one instruction every six cycles with a latency of 26 cycles.

0 commit comments

Comments
 (0)