You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm creating this issue to outline/plan work for the desktop app that needs to be done before release. The work outlined here has a particular focus on builds/installation.
Currently, we create a zip build for all platforms:
It could be an improvement to use some of the platform specific build targets supported by electron-builder. After a bit of talking with @garrettjstevens and @cmdcolin , it seems like the following targets might make sense:
MacOS: dmg
Linux: AppImage
Windows: nsis
Next, we are probably going to need some CI to do desktop builds, and possible to copy the builds to S3 like the web.
Finally, we need to figure out app signing for MacOS (#664), and Windows (#665)
I'm making this more general issue to track progress on this front.
Create platform specific builds
Set up CI for desktop builds
sign apps (and get working with CI)
The text was updated successfully, but these errors were encountered:
I agree that updating without explicit approval from the user makes me nervous. It looks like for those three targets, though, we can still use the auto-updating machinery to update in place, so users can still update from within the app, but make it something users have to confirm.
I think a subtle notification in the UI of a new version would be nice, both for desktop and possibly for web when running in admin mode.
I'm creating this issue to outline/plan work for the desktop app that needs to be done before release. The work outlined here has a particular focus on builds/installation.
Currently, we create a zip build for all platforms:
jbrowse-components/products/jbrowse-desktop/package.json
Lines 98 to 111 in d690c35
It could be an improvement to use some of the platform specific build targets supported by electron-builder. After a bit of talking with @garrettjstevens and @cmdcolin , it seems like the following targets might make sense:
dmg
AppImage
nsis
Next, we are probably going to need some CI to do desktop builds, and possible to copy the builds to S3 like the web.
Finally, we need to figure out app signing for MacOS (#664), and Windows (#665)
I'm making this more general issue to track progress on this front.
The text was updated successfully, but these errors were encountered: