Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish desktop builds for release #2020

Closed
3 tasks done
elliothershberg opened this issue May 27, 2021 · 4 comments · Fixed by #2029
Closed
3 tasks done

Polish desktop builds for release #2020

elliothershberg opened this issue May 27, 2021 · 4 comments · Fixed by #2029
Assignees
Labels
enhancement New feature or request

Comments

@elliothershberg
Copy link
Member

elliothershberg commented May 27, 2021

I'm creating this issue to outline/plan work for the desktop app that needs to be done before release. The work outlined here has a particular focus on builds/installation.

Currently, we create a zip build for all platforms:

"win": {
"target": "zip",
"artifactName": "jbrowse-desktop-${version}-win.${ext}"
},
"linux": {
"target": "zip",
"artifactName": "jbrowse-desktop-${version}-linux.${ext}",
"executableName": "jbrowse-desktop"
},
"mac": {
"category": "public.app-category.utilities",
"target": "zip",
"artifactName": "jbrowse-desktop-${version}-mac.${ext}"
},

It could be an improvement to use some of the platform specific build targets supported by electron-builder. After a bit of talking with @garrettjstevens and @cmdcolin , it seems like the following targets might make sense:

  • MacOS: dmg
  • Linux: AppImage
  • Windows: nsis

Next, we are probably going to need some CI to do desktop builds, and possible to copy the builds to S3 like the web.

Finally, we need to figure out app signing for MacOS (#664), and Windows (#665)

I'm making this more general issue to track progress on this front.

  • Create platform specific builds
  • Set up CI for desktop builds
  • sign apps (and get working with CI)
@elliothershberg elliothershberg added the enhancement New feature or request label May 27, 2021
@elliothershberg elliothershberg self-assigned this May 27, 2021
@garrettjstevens
Copy link
Collaborator

What's the plan with updating? Are we going to use electron-builder's auto-updating, or have users update manually?

@cmdcolin
Copy link
Collaborator

I might say no autoupdating, but maybe a little notification that tells users if an update is available would be nice

@elliothershberg
Copy link
Member Author

Good question! I don't have a strong opinion. Maybe we should make it an actual part of the app UI to notify of updates and re-install?

@garrettjstevens
Copy link
Collaborator

I agree that updating without explicit approval from the user makes me nervous. It looks like for those three targets, though, we can still use the auto-updating machinery to update in place, so users can still update from within the app, but make it something users have to confirm.

I think a subtle notification in the UI of a new version would be nice, both for desktop and possibly for web when running in admin mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants