Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Copy to clipboard" in Share session dialog should be in disabled state while waiting for session link to generate #1586

Closed
cmdcolin opened this issue Dec 23, 2020 · 2 comments · Fixed by #1598
Closed

"Copy to clipboard" in Share session dialog should be in disabled state while waiting for session link to generate #1586

cmdcolin opened this issue Dec 23, 2020 · 2 comments · Fixed by #1598
Assignees
@peterkxie
Labels
bug Something isn't working

Comments

@cmdcolin
Copy link
Collaborator

The "copy to clipboard" gets enabled before a share link is enabled and might have a "long session URL" in place before the short one comes into existence

Probably we should make the copy to clipboard button wait until short link arrives
@cmdcolin cmdcolin added the bug Something isn't working label Dec 23, 2020
@cmdcolin
Copy link
Collaborator Author

Found pairing with @garrettjstevens

@rbuels
Copy link
Contributor

rbuels commented Dec 23, 2020

cc @peterkxie

@peterkxie peterkxie self-assigned this Jan 5, 2021
@peterkxie peterkxie mentioned this issue Jan 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peterkxie peterkxie

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable 'copy to clipboard' while share url being generated GMOD/jbrowse-components
3 participants
@rbuels @cmdcolin @peterkxie