From 12bf104e0380d9d2a0a277ddc4f530e638979b14 Mon Sep 17 00:00:00 2001 From: Garrett Stevens Date: Wed, 13 Sep 2023 20:06:51 -0600 Subject: [PATCH] Add comment to exitCode cleanup --- products/jbrowse-cli/src/commands/add-assembly.test.ts | 1 + products/jbrowse-cli/src/commands/add-connection.test.ts | 1 + products/jbrowse-cli/src/commands/add-track.test.ts | 1 + products/jbrowse-cli/src/commands/admin-server.test.ts | 1 + products/jbrowse-cli/src/commands/create.test.ts | 1 + products/jbrowse-cli/src/commands/remove-track.test.ts | 1 + products/jbrowse-cli/src/commands/set-default-session.test.ts | 1 + products/jbrowse-cli/src/commands/text-index.test.ts | 1 + products/jbrowse-cli/src/commands/upgrade.test.ts | 1 + 9 files changed, 9 insertions(+) diff --git a/products/jbrowse-cli/src/commands/add-assembly.test.ts b/products/jbrowse-cli/src/commands/add-assembly.test.ts index 009fa5b0ab..fc5313f6de 100644 --- a/products/jbrowse-cli/src/commands/add-assembly.test.ts +++ b/products/jbrowse-cli/src/commands/add-assembly.test.ts @@ -26,6 +26,7 @@ const baseSequence = { adapter: {}, } +// Cleaning up exitCode in Node.js 20, xref https://github.com/jestjs/jest/issues/14501 afterAll(() => (process.exitCode = 0)) describe('add-assembly', () => { diff --git a/products/jbrowse-cli/src/commands/add-connection.test.ts b/products/jbrowse-cli/src/commands/add-connection.test.ts index a4f2fd7e29..5dc4ff0820 100644 --- a/products/jbrowse-cli/src/commands/add-connection.test.ts +++ b/products/jbrowse-cli/src/commands/add-connection.test.ts @@ -61,6 +61,7 @@ const setupWithDateMock = setup Date.now = originalDateNow }) +// Cleaning up exitCode in Node.js 20, xref https://github.com/jestjs/jest/issues/14501 afterAll(() => (process.exitCode = 0)) describe('add-connection', () => { diff --git a/products/jbrowse-cli/src/commands/add-track.test.ts b/products/jbrowse-cli/src/commands/add-track.test.ts index 78263b0101..a94f66fe6f 100644 --- a/products/jbrowse-cli/src/commands/add-track.test.ts +++ b/products/jbrowse-cli/src/commands/add-track.test.ts @@ -40,6 +40,7 @@ function init2bit(ctx: { dir: string }) { ) } +// Cleaning up exitCode in Node.js 20, xref https://github.com/jestjs/jest/issues/14501 afterAll(() => (process.exitCode = 0)) describe('add-track', () => { diff --git a/products/jbrowse-cli/src/commands/admin-server.test.ts b/products/jbrowse-cli/src/commands/admin-server.test.ts index 263d2f8fa5..fc07d360d3 100644 --- a/products/jbrowse-cli/src/commands/admin-server.test.ts +++ b/products/jbrowse-cli/src/commands/admin-server.test.ts @@ -85,6 +85,7 @@ async function killExpress({ stdout }: { stdout: string }) { }) } +// Cleaning up exitCode in Node.js 20, xref https://github.com/jestjs/jest/issues/14501 afterAll(() => (process.exitCode = 0)) describe('admin-server', () => { diff --git a/products/jbrowse-cli/src/commands/create.test.ts b/products/jbrowse-cli/src/commands/create.test.ts index ebfb276f16..73a94e0345 100644 --- a/products/jbrowse-cli/src/commands/create.test.ts +++ b/products/jbrowse-cli/src/commands/create.test.ts @@ -64,6 +64,7 @@ function mockWrongSite(exampleSite: Scope) { .reply(200, 'I am the wrong type', { 'Content-Type': 'application/json' }) } +// Cleaning up exitCode in Node.js 20, xref https://github.com/jestjs/jest/issues/14501 afterAll(() => (process.exitCode = 0)) describe('create', () => { diff --git a/products/jbrowse-cli/src/commands/remove-track.test.ts b/products/jbrowse-cli/src/commands/remove-track.test.ts index 41e0256de4..f308264066 100644 --- a/products/jbrowse-cli/src/commands/remove-track.test.ts +++ b/products/jbrowse-cli/src/commands/remove-track.test.ts @@ -9,6 +9,7 @@ import { setup, readConf } from '../testUtil' const twoPath = path.join(__dirname, '..', '..', 'test', 'data', 'simple.2bit') +// Cleaning up exitCode in Node.js 20, xref https://github.com/jestjs/jest/issues/14501 afterAll(() => (process.exitCode = 0)) describe('add-assembly', () => { diff --git a/products/jbrowse-cli/src/commands/set-default-session.test.ts b/products/jbrowse-cli/src/commands/set-default-session.test.ts index 6868a5f21f..6cab362c84 100644 --- a/products/jbrowse-cli/src/commands/set-default-session.test.ts +++ b/products/jbrowse-cli/src/commands/set-default-session.test.ts @@ -75,6 +75,7 @@ const setupWithAddTrack = setup }) .command(['add-track', simpleBam, '--load', 'copy']) +// Cleaning up exitCode in Node.js 20, xref https://github.com/jestjs/jest/issues/14501 afterAll(() => (process.exitCode = 0)) describe('set-default-session', () => { diff --git a/products/jbrowse-cli/src/commands/text-index.test.ts b/products/jbrowse-cli/src/commands/text-index.test.ts index c4763db0a7..b5f4615f48 100644 --- a/products/jbrowse-cli/src/commands/text-index.test.ts +++ b/products/jbrowse-cli/src/commands/text-index.test.ts @@ -65,6 +65,7 @@ function verifyIxxFiles(ctx: string, base = 'volvox') { expect(ixxdata).toMatchSnapshot() } +// Cleaning up exitCode in Node.js 20, xref https://github.com/jestjs/jest/issues/14501 afterAll(() => (process.exitCode = 0)) // Base text index command diff --git a/products/jbrowse-cli/src/commands/upgrade.test.ts b/products/jbrowse-cli/src/commands/upgrade.test.ts index eef52c5817..e43977e18b 100644 --- a/products/jbrowse-cli/src/commands/upgrade.test.ts +++ b/products/jbrowse-cli/src/commands/upgrade.test.ts @@ -75,6 +75,7 @@ function mockV2Zip(exampleSite: Scope) { ) } +// Cleaning up exitCode in Node.js 20, xref https://github.com/jestjs/jest/issues/14501 afterAll(() => (process.exitCode = 0)) describe('upgrade', () => {