Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MAPL dependencies for MAPL-as-library in CMake #2320

Merged
merged 3 commits into from
Sep 15, 2023

Conversation

mathomp4
Copy link
Member

Description

This is an attempt to fix an issue being seen by @climbfuji in using the latest MAPL in UFS. I believe the problem is that now MAPL is being built with pFlogger (and fArgparse?) support and GOCART-as-UFS builds doesn't know that those are needed.

I tried to do some limited testing locally and I think this solves at least the CMake problems. The main thing is I can't do any building because I don't think I have the right flags set (since I'm building as -DUFS_GOCART=ON) and so I get:

/Users/mathomp4/Models/GOCART-LikeUFS/GOCART/Process_Library/MieQuery.H:156:132:

  156 |              pmom(__DIMS__,i,j)  =  __RHINTERP5__(this%pmom, irh, arh, channel, bin, i, j, rh)
      |                                                                                                                                    1
Error: Line truncated at (1) [-Werror=line-truncation]

Related Issue

Motivation and Context

Let's users of MAPL-as-library via find_package(MAPL) get dependencies correct.

How Has This Been Tested?

Not much at all.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@mathomp4 mathomp4 self-assigned this Aug 30, 2023
climbfuji pushed a commit to climbfuji/GOCART that referenced this pull request Aug 30, 2023
… is merged and finds its way into the ufs-weather-model dependency tree
tclune
tclune previously approved these changes Aug 31, 2023
@mathomp4
Copy link
Member Author

I have tested this with GEOS and it of course works since we don't do find_package(MAPL). I'll hold off on un-drafting this until @climbfuji can confirm or deny if UFS likes it.

climbfuji pushed a commit to climbfuji/GOCART that referenced this pull request Sep 7, 2023
…/MAPL#2320 is merged and finds its way into the ufs-weather-model dependency tree
@mathomp4 mathomp4 marked this pull request as ready for review September 14, 2023 17:22
@mathomp4 mathomp4 requested a review from a team as a code owner September 14, 2023 17:22
@climbfuji
Copy link

@mathomp4 Just wanted to let you know that I am doing the spack-stack 1.5.0 release/installs this week and last week, therefore no time to test, sorry.

@mathomp4
Copy link
Member Author

@mathomp4 Just wanted to let you know that I am doing the spack-stack 1.5.0 release/installs this week and last week, therefore no time to test, sorry.

@climbfuji Well, at this point it can't be worse than what we have now. I figure get it in and if it works, huzzah! If not, well, new data point! 😄

@climbfuji
Copy link

Fine with me!

@mathomp4 mathomp4 merged commit e407849 into main Sep 15, 2023
27 checks passed
@mathomp4 mathomp4 deleted the hotfix/mathomp4/fix-mapl-cmake-package branch September 15, 2023 16:26
climbfuji pushed a commit to climbfuji/GOCART that referenced this pull request Sep 25, 2023
… is merged and finds its way into the ufs-weather-model dependency tree
climbfuji pushed a commit to climbfuji/GOCART that referenced this pull request Sep 25, 2023
…/MAPL#2320 is merged and finds its way into the ufs-weather-model dependency tree
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants