Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PrimitiveNode.Equals() should not compare DecimalMetadata #66

Closed
philjdf opened this issue Aug 1, 2019 · 3 comments
Closed

PrimitiveNode.Equals() should not compare DecimalMetadata #66

philjdf opened this issue Aug 1, 2019 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@philjdf
Copy link
Contributor

philjdf commented Aug 1, 2019

The call to LogicalType.Equals() now implies comparison of the decimal data if the type is Decimal.

Also DecimalMetaData naively compares its tuple values. But in truth, if both left and right have IsSet = false, the other properties should be ignored.

@GPSnoopy GPSnoopy self-assigned this Aug 1, 2019
@GPSnoopy GPSnoopy added the bug Something isn't working label Aug 1, 2019
@GPSnoopy
Copy link
Contributor

GPSnoopy commented Aug 1, 2019

This was highlighted by a clone of a TimeStamp node (UTC true, Micros) compared with its original. Worth writing a quick unit test.

@GPSnoopy
Copy link
Contributor

GPSnoopy commented Aug 6, 2019

As suggest by @philjdf in an IRL discussion, maybe we can just completely remove DecimalMetadata as it's made redundant by the new LogicalType implementation.

https://github.com/G-Research/ParquetSharp/search?q=DecimalMetadata&unscoped_q=DecimalMetadata

@GPSnoopy
Copy link
Contributor

Fixed in 2.0.0-beta3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants