Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework and fix associated const visibility for impl items #6785

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Rework and fix associated const visibility for impl items #6785

wants to merge 4 commits into from

Conversation

tritao
Copy link
Contributor

@tritao tritao commented Dec 11, 2024 •
edited
Loading

Description

Fixes #6772.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@tritao tritao added the compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen label Dec 11, 2024
@tritao tritao self-assigned this Dec 11, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 11, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #6785 will not alter performance

Comparing tritao:associated-const-visibility (c5036b0) with master (192f163)

Summary

✅ 22 untouched benchmarks

@tritao tritao force-pushed the associated-const-visibility branch 2 times, most recently from 9a9acf4 to 12cbb05 Compare December 16, 2024 13:00
@tritao tritao force-pushed the associated-const-visibility branch from 12cbb05 to c5036b0 Compare December 16, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tritao tritao

Labels
compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Associated constant visibility is broken
1 participant
@tritao