Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Statically forbid usage of revert in predicates #5986

Open
IGI-111 opened this issue May 10, 2024 · 1 comment · May be fixed by #6290
Open

Statically forbid usage of revert in predicates #5986

IGI-111 opened this issue May 10, 2024 · 1 comment · May be fixed by #6290
Labels
compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen compiler: ui Mostly compiler messages good first issue Good for newcomers

Comments

@IGI-111
Copy link
Contributor

IGI-111 commented May 10, 2024

Using reverts in predicates produces a panic as they are illegal. Using them in that context should produce an error at compile time.
@IGI-111 IGI-111 added good first issue Good for newcomers compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen compiler: ui Mostly compiler messages labels May 10, 2024
@xunilrj xunilrj mentioned this issue May 10, 2024
Closed
@bolajahmad
Copy link

I'd like to take this on, seems like a good issue to start with.

If I understand correctly, the revert (RVRT code) should not be allowed on predicates, currently it's not specified anywhere but we need to do that.

@bolajahmad bolajahmad linked a pull request Jul 22, 2024 that will close this issue
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen compiler: ui Mostly compiler messages good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add RVRT to unallowed opcodes for predicates bolajahmad/sway
2 participants
@IGI-111 @bolajahmad