Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a flag to forc contract-id command to show it in bech32 format #5842

Closed
kayagokalp opened this issue Apr 10, 2024 · 9 comments
Closed

Add a flag to forc contract-id command to show it in bech32 format #5842

kayagokalp opened this issue Apr 10, 2024 · 9 comments
Assignees
Labels
enhancement New feature or request forc good first issue Good for newcomers

Comments

@kayagokalp
Copy link
Member

Currently forc-contract-id show the contract id in hex format but it is possible that users may want to get in bech32 format as well. We should have a flag for this

@kayagokalp kayagokalp added enhancement New feature or request forc good first issue Good for newcomers labels Apr 10, 2024
@ADTmux
Copy link

ADTmux commented Apr 11, 2024

Hey, I would like to work on this!

@kayagokalp
Copy link
Member Author

Hey, I would like to work on this!

Sounds great! go for it :) assigned to you

@ADTmux
Copy link

ADTmux commented Apr 18, 2024

Hey, quick question, I recently tried to modify https://github.com/FuelLabs/sway/blob/master/forc/src/ops/forc_contract_id.rs and I wanted to test my modifications to the command, could you please lead me to the right part of the documentation that would help me modify the forc binary installed in my setup to get started on this

@kayagokalp
Copy link
Member Author

Hey, quick question, I recently tried to modify https://github.com/FuelLabs/sway/blob/master/forc/src/ops/forc_contract_id.rs and I wanted to test my modifications to the command, could you please lead me to the right part of the documentation that would help me modify the forc binary installed in my setup to get started on this

Great to hear that you are making progress! You can build your version of forc with cargo build and use forc with absolute path ./target/debug/forc from the root of the sway repo. Or you can remove your current forc installation (if you installed it through cargo check your ./cargo/bin/ or if you installed it from fuelup check your ./fuelup/bin) and install your modified version with cargo install. Also consider opening a PR once you feel like it to start review process.

@ADTmux
Copy link

ADTmux commented Apr 21, 2024

Hi, I did integrate the flag, I wanted a hint on how the forc contract-id --help command prints out information so that I could integrate a line on --bech32

Screenshot 2024-04-21 at 5 46 43 AM

@ADTmux
Copy link

ADTmux commented Apr 30, 2024

Hi @kayagokalp could you assist me with this last bit? :)

@kayagokalp
Copy link
Member Author

Hey @ADTmux please open a PR so that i can see your WIP and assist you better. You should add this new flag to https://github.com/FuelLabs/sway/blob/daee1c247c86038bf9a3faefbca80d0aca4ebf0e/forc/src/cli/commands/contract_id.rs#L18C12-L18C19

@sdankel
Copy link
Member

sdankel commented Aug 29, 2024

@kayagokalp Can we close this since we are removing Bech32 format from the wallet?

@kayagokalp
Copy link
Member Author

Yes that seems reasonable to me :)

@kayagokalp kayagokalp closed this as not planned Won't fix, can't repro, duplicate, stale Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request forc good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants