Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move storage slots to the *-abi.json #5135

Open
luizstacio opened this issue Sep 20, 2023 · 0 comments
Open

Move storage slots to the *-abi.json #5135

luizstacio opened this issue Sep 20, 2023 · 0 comments

Comments

@luizstacio
Copy link
Member

In the past, we created storage slots JSON to keep the ABI clean of data specific to deployment. However, the storage slots were not a "required" file to initialize variables at deployment time.

Once we moved to "require" the storage slots, it reduced the ergonomic and required SDKs to check if a file exists and import automatically or ask the user to import it also. When dealing with deployment on browser envs, the work turns a bit worse and adds more steps to the final developer.

This problem is solved in the TS-SDK and RS-SDK, and the purpose here is to improve the abi. This isn't a blocker. It's just an improvement on DevEx.

Notes:

  • Is this a valid work? If no, why we should keep it as it is?
  • TS-SDK and RS-SDK are aware of the request, and the effort to implement it would be ok. They also agree this would be a good improvement.

Other potential features to be created:

  • With the storage slots inside the abi, we could also consider adding types for the initialized slots.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant