Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yellow warning triangle not necessary in this case #1148

Closed
HoTandy opened this issue Mar 19, 2024 · 1 comment · Fixed by #1186
Closed

Yellow warning triangle not necessary in this case #1148

HoTandy opened this issue Mar 19, 2024 · 1 comment · Fixed by #1186
Assignees
Labels
bug Something isn't working

Comments

@HoTandy
Copy link
Contributor

HoTandy commented Mar 19, 2024

What version of Wallet are you using?

Version: 0.15.2

What is happening?

When connecting an app to the wallet, in this case the bridge, the wallet tells you what the app is allowed to do, in this case it gives the following list with a green tick or a red cross next to each point

(green tick) View your account address
(green tick) Request transaction approval
(green tick) Request message signature
(green tick) Read your transaction history
(red cross) View your private keys

image

After confirmation, a yellow triangle is is shown above the app connection box as shown in the image below

image

My assumption is that because all the points are not a green tick, then a warning is given in the form of the yellow warning triangle.

In reality, no warning is required in this case, the user should be happy that the app cannot view the private key.

steps to reproduce

Check under ### What is happening

How it should behave?

Generally speaking, maybe we should have a re-think on how the information should be displayed to the user. In this case I would expect a green tick rather than a yellow warning triangle.

Maybe the last message should read:

(green tick) Cannot view your private keys

and then a green tick would be displayed rather than a yellow warning triangle

If there's a red cross against any of the other 4 points, namely:

View your account address
Request transaction approval
Request message signature
Read your transaction history

Then I don't think that's a problem, we should still display a green tick as an overall status. But also conversely maybe there should be a yellow warning triangle if an app can Read your transaction history or View your account address

What os are you seeing the problem on?

Mac/Apple Desktop

What browser?

Chrome

What is your browser version?

Version 122.0.6261.112 (Official Build) (x86_64)

@HoTandy HoTandy added bug Something isn't working triage labels Mar 19, 2024
@helciofranco helciofranco self-assigned this Mar 22, 2024
@helciofranco
Copy link
Member

helciofranco commented Mar 25, 2024

@HoTandy does that make sense?

I replaced that warning icon with a grey info circle icon.
Also fixed that wrong alignment to the right, it was wonky.

Screenshot 2024-03-25 at 11 42 57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants