Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider automating package publishing on every PR #3671

Open
petertonysmith94 opened this issue Feb 6, 2025 · 2 comments
Open

Consider automating package publishing on every PR #3671

petertonysmith94 opened this issue Feb 6, 2025 · 2 comments
Labels
chore Issue is a chore

Comments

@petertonysmith94
Copy link
Contributor

petertonysmith94 commented Feb 6, 2025

Summary

After migrating our package publishing for next and PR from NPM to GitHub packages in #3639, we could consider automatically publishing every PR to GitHub packages.

This will also enable us to:

  • Run associated integration tests on every PR
  • Remove the manual pr-release workflow.

Follow ups

  • We could consider an automated job to remove these published packages from GitHub packages (this could be via a CRON job).
@petertonysmith94 petertonysmith94 added the chore Issue is a chore label Feb 6, 2025
@arboleya
Copy link
Member

arboleya commented Feb 6, 2025

A cleanup action to purge what's been merged is still valid, but because we're open-source, it seems we don't necessarily pay for storage for GitHub packages. This means that the cleanup routine can be a follow-up issue.

@arboleya
Copy link
Member

arboleya commented Feb 7, 2025

We can also have a simple workflow/test that assets something by installing the tag from scratch (after publishing) instead of referencing it from the workspace (before publishing). This is to ensure that the published tag can be installed/used.

With the above, I believe we don't need:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore
Projects
None yet
Development

No branches or pull requests

2 participants