Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exceeding Maximum Number of Inputs When Funding a Transaction #2420

Closed
Torres-ssf opened this issue May 30, 2024 · 2 comments · Fixed by #2822
Closed

Exceeding Maximum Number of Inputs When Funding a Transaction #2420

Torres-ssf opened this issue May 30, 2024 · 2 comments · Fixed by #2822
Labels
chore Issue is a chore

Comments

@Torres-ssf
Copy link
Contributor

In a similar situation to issue #2419, when funding a transaction in the fund method, we do not validate whether the number of inputs exceeds the maximum allowed for a transaction.

Action Required:

  • Add validation to ensure the number of inputs does not exceed the maximum limit.
  • Ensure an appropriate error is thrown if the limit is exceeded.
@Torres-ssf Torres-ssf added the chore Issue is a chore label May 30, 2024
@mvares
Copy link
Contributor

mvares commented Jun 3, 2024

hi @Torres-ssf

The maximum allowed for a transaction is the maxFee?

@Torres-ssf
Copy link
Contributor Author

@mgrithm When calculated properly, the maxFee is the fee value charged when processing the transaction.

This issue is related to not exceeding the limit of inputs allowed within a transaction. This value is set within the chain config

@arboleya arboleya added the p1 label Jun 9, 2024
@arboleya arboleya added this to the 0.x post-launch milestone Jun 12, 2024
@arboleya arboleya added p2 and removed p1 labels Jul 19, 2024
@arboleya arboleya removed this from the 0.x post-launch milestone Jul 19, 2024
@arboleya arboleya added p1 and removed p2 labels Jul 19, 2024
@arboleya arboleya removed the p1 label Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants