Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove externalLoggedTypes from Interface #1117

Closed
nedsalk opened this issue Jul 24, 2023 · 0 comments · Fixed by #1936
Closed

Remove externalLoggedTypes from Interface #1117

nedsalk opened this issue Jul 24, 2023 · 0 comments · Fixed by #1936
Assignees
@Torres-ssf
Labels
chore Issue is a chore

Comments

@nedsalk
Copy link
Contributor

nedsalk commented Jul 24, 2023

Currently Interface.externalLoggedTypes is being used as a way to decode logged types during multicall. This shouldn't be the case, as an Interface shouldn't be concerned with some other Interface. The externalLoggedTypes logic should be moved elsewhere; probably somewhere in BaseInvocationScope or similar.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Torres-ssf Torres-ssf

Labels
chore Issue is a chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore!: remove externalLoggedTypes from Interface class FuelLabs/fuels-ts
2 participants
@nedsalk @Torres-ssf