Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use true bytes not compressed bytes for calculated cost_per_byte in algorithm #2244

Closed
MitchTurner opened this issue Sep 24, 2024 · 0 comments · Fixed by #2252
Closed

Use true bytes not compressed bytes for calculated cost_per_byte in algorithm #2244

MitchTurner opened this issue Sep 24, 2024 · 0 comments · Fixed by #2252
Assignees

Comments

@MitchTurner
Copy link
Member

The committer isn't aware of the original byte size of each block, just the compressed bytes. We need this information to calculate the real value of cost_per_byte.

We should record the bytes for each block in unrecorded_blocks and use that value when updating the latest_cost_per_byte and ensure that is the case for any place we are using the block bytes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant