Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate removing DeadlineClock #1917

Closed
MitchTurner opened this issue May 30, 2024 · 2 comments · Fixed by #2109
Closed

Investigate removing DeadlineClock #1917

MitchTurner opened this issue May 30, 2024 · 2 comments · Fixed by #2109
Assignees
@AurelienFT
Labels
good first issue Good for newcomers

Comments

@MitchTurner
Copy link
Member

It got removed from one of its spots here:
#1914

Might be worth looking at using Interval everywhere instead.
@MitchTurner MitchTurner mentioned this issue May 30, 2024
Merged
1 task
@xgreenx xgreenx added the good first issue Good for newcomers label Aug 12, 2024
@xgreenx xgreenx mentioned this issue Aug 16, 2024
Merged
9 tasks
@Dentosal
Copy link
Member

Issue here is that if we error during block production, new blocks wont be produced anymore and the service hangs.

@Dentosal Dentosal assigned Dentosal and unassigned Dentosal Aug 19, 2024
@AurelienFT
Copy link
Contributor

I don't have permission to assign myself yet, so placing this comment as an assignment placeholder

This was referenced Aug 19, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AurelienFT AurelienFT

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove deadline clock in POA and replace with tokio time functions. FuelLabs/fuel-core
4 participants
@Dentosal @MitchTurner @xgreenx @AurelienFT