Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test to verify that malleable fields don't affect validity of the block #1620

Closed
xgreenx opened this issue Jan 24, 2024 · 2 comments
Closed
Assignees

Comments

@xgreenx
Copy link
Collaborator

xgreenx commented Jan 24, 2024

Add unit test to executor or integration test to the fuel-core that verifies validity of the block is not affected by the set malleable fields.

Implementation details

The bytecode can take the hash of the transaction from VM memory and check that it is equal to the tx_id in the begging of the memory.

@xgreenx xgreenx changed the title Test to verify that malleable doesn't affect validity of the block Add a test to verify that malleable doesn't affect validity of the block Jan 24, 2024
@xgreenx xgreenx changed the title Add a test to verify that malleable doesn't affect validity of the block Add a test to verify that malleable fields don't affect validity of the block Jan 24, 2024
@Dentosal
Copy link
Member

Included in FuelLabs/fuel-vm#678

@xgreenx
Copy link
Collaborator Author

xgreenx commented Mar 4, 2024

Done as part of the #1714

@xgreenx xgreenx closed this as completed Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants