Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove maturity field from the Coin #1618

Closed
xgreenx opened this issue Jan 24, 2024 · 4 comments
Closed

Remove maturity field from the Coin #1618

xgreenx opened this issue Jan 24, 2024 · 4 comments
Assignees

Comments

@xgreenx
Copy link
Collaborator

xgreenx commented Jan 24, 2024

When we create a Coin, we set maturity to zero because the user doesn't have a way to specify the maturity for the Output. Because of that, it is a useless field right now.

Either we need to provide a way for the user to set it or remove it completely.

As a fast solution, we can remove it for now and add support for it later with the upgrade.

@Voxelot
Copy link
Member

Voxelot commented Feb 9, 2024

@xgreenx should this issue be closed as well? Also we should update the specs.

@xgreenx
Copy link
Collaborator Author

xgreenx commented Feb 12, 2024

It is not implemented yet, so we don't need to close it, we closed the duplicate=) Yeah, we need to update the specification as well not to include maturity in the Coin input.

@Dentosal
Copy link
Member

Mostly implemented in FuelLabs/fuel-vm#684, although we still need a follow-up for fuel-core after that.

@xgreenx
Copy link
Collaborator Author

xgreenx commented Mar 4, 2024

Finished with #1714

@xgreenx xgreenx closed this as completed Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants