Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Transaction Fee Interface Changes #1606

Closed
MitchTurner opened this issue Jan 18, 2024 · 3 comments
Closed

Feature: Transaction Fee Interface Changes #1606

MitchTurner opened this issue Jan 18, 2024 · 3 comments
Assignees
Labels
epic An epic is a high-level master issue for large pieces of work.

Comments

@MitchTurner
Copy link
Member

MitchTurner commented Jan 18, 2024

This is a prerequisite to working on DA block submission. We want to define the interface that the SDK teams can depend on for determining transaction fee.

Background

It costs a variable amount to post the blocks to the DA layer, we are trying to minimize that cost with DA block compression, but there are a lot of things that we can't control. Even if DA block cost was constant, the submitter may be the only submitter for that block or there may be many submitters who could share the cost. But, the cost isn't constant because ETH gas prices change.

Interface

We just want to take these things into account to give tx submitters as much visibility into and control of what there fee is going to be. And also flexibility for the implementer to find them an answer.

@MitchTurner
Copy link
Member Author

I'm thinking the best approach is to hide the rules for determining the next block's maximum gas price, and just expose that number to any tx builders via a client endpoint.

@xgreenx xgreenx added the epic An epic is a high-level master issue for large pieces of work. label Feb 4, 2024
@MitchTurner MitchTurner changed the title Feature: Transaction Fee Interface Changes Feature: Gas Price and Transaction Fee Changes Feb 22, 2024
@MitchTurner MitchTurner changed the title Feature: Gas Price and Transaction Fee Changes Feature: Dynamic Gas Price Feb 22, 2024
@MitchTurner MitchTurner changed the title Feature: Dynamic Gas Price Feature: Transaction Fee Interface Changes Feb 22, 2024
@xgreenx
Copy link
Collaborator

xgreenx commented Mar 7, 2024

Implemented with #1714 and fuel-core 0.23.0 release

@xgreenx xgreenx closed this as completed Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic An epic is a high-level master issue for large pieces of work.
Projects
None yet
Development

No branches or pull requests

2 participants