You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Makes sense given the context that this is on a MessageCoin, as it should be implicit that the amount of the asset is related to the base id.
However, from a user perspective it could also be confusing if they are trying to understand how to parse messages. Since if an erc20 is bridged, they may confuse the amount and asset with the erc20 coin they wanted to bridge, which would actually be encoded into the data section.
Since it's implicit anyways, do we even need the asset field here at all?
I think it is better to keep asset_id because it allows to fetch all information about the coin in one query. Without it we need to request chain_info with ConsensusParameters to be able to identify the base AssetId.
Makes sense given the context that this is on a MessageCoin, as it should be implicit that the amount of the asset is related to the base id.
However, from a user perspective it could also be confusing if they are trying to understand how to parse messages. Since if an erc20 is bridged, they may confuse the amount and asset with the erc20 coin they wanted to bridge, which would actually be encoded into the data section.
Since it's implicit anyways, do we even need the asset field here at all?
Originally posted by @Voxelot in #1339 (comment)
The text was updated successfully, but these errors were encountered: