Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove asset_id field from MessageCoin #1365

Closed
bvrooman opened this issue Sep 13, 2023 · 1 comment
Closed

Remove asset_id field from MessageCoin #1365

bvrooman opened this issue Sep 13, 2023 · 1 comment

Comments

@bvrooman
Copy link
Contributor

bvrooman commented Sep 13, 2023

Makes sense given the context that this is on a MessageCoin, as it should be implicit that the amount of the asset is related to the base id.

However, from a user perspective it could also be confusing if they are trying to understand how to parse messages. Since if an erc20 is bridged, they may confuse the amount and asset with the erc20 coin they wanted to bridge, which would actually be encoded into the data section.

Since it's implicit anyways, do we even need the asset field here at all?

Originally posted by @Voxelot in #1339 (comment)

@xgreenx
Copy link
Collaborator

xgreenx commented Nov 23, 2023

I think it is better to keep asset_id because it allows to fetch all information about the coin in one query. Without it we need to request chain_info with ConsensusParameters to be able to identify the base AssetId.

@xgreenx xgreenx closed this as completed Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants