Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whole Match and Per-Word matching methods are not working for Cyrillic words. #91

Closed
angelvardin opened this issue Aug 4, 2018 · 2 comments
Assignees
Labels
Bug Something isn't working

Comments

@angelvardin
Copy link

Description

Whole Match and Per-Word matching methods are not censoring Cyrillic words and they remain the same. Exact Match and Partial Match are working correctly.

Details (Bugs Only)

Chrome Version: 68.0.3440.84
Firefox Version: 61.0.1
Extension Version: 1.0.15
Operating System: Win 10

Steps to reproduce (Bugs only)

  1. Add new Cyrillic word in the profanity list of the extension.
    example words: котка (cat in English), куче (dog in English), врата (door in English),
    прозорец (window in English), маса (table in English)
  2. Set matching method of this word to Whole Match.
  3. Type censored word in Google or other popular search engine.
@richardfrost
Copy link
Collaborator

I just pushed an update (1.1.0) that should hopefully address this issue. Please let me know once you get the update if the problem is fixed or not.

It turns out the issue is that JavaScript doesn't handle UTF-8 characters inside RegExp (the mechanism the filter uses to identify which words to target) very well. I have introduced a workaround and in my testing have had success. Thanks for pointing out this issue, and hopefully it shouldn't be a problem anymore.

@richardfrost
Copy link
Collaborator

I'm going to go ahead and close this, because I think it was resolved. If not, feel free to re-open the issue.

@richardfrost richardfrost added the Bug Something isn't working label May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants