Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discovery+ no longer filtering #550

Closed
Jenron3000 opened this issue Apr 28, 2024 · 7 comments
Closed

Discovery+ no longer filtering #550

Jenron3000 opened this issue Apr 28, 2024 · 7 comments
Assignees
Labels
Bug Something isn't working

Comments

@Jenron3000
Copy link

🐛 Discovery+ no longer muting audio

I have tried advanced and deep filtering options as well as changing from browser mute, to video mute, ect.
Something changed because it has been working wonderfully.
The captions are being filter but the audio doesn't mute
I've tried multiple browsers to no avail.
Something changed because it has been working wonderfully.
Thank you so much for your work on this filter.

💻 Details

  • Device: MacBook Pro
  • OS: MacOS 12.7.1
  • Browser: Brave, Chrome, Firefox.
  • Browser Version: Version 1.64.122 Chromium: 123.0.6312.122 (Official Build) (x86_64)]
  • Affected site(s): Discoveryplus.com
@Jenron3000 Jenron3000 added the Bug Something isn't working label Apr 28, 2024
@richardfrost
Copy link
Collaborator

richardfrost commented Apr 28, 2024

Hi @Jenron3000, thanks for reporting the issue. I'm glad that you are enjoying the filter when it is working for you though! Hopefully we can get it fixed up again.

It looks like Discovery+ has changed quite a bit about their website, but I do have a potential update that will hopefully fix it. Could you give it a try and let me know how it works for you?

{
  "www.discoveryplus.com": [
    {
      "className": "sc-iMWBiJ",
      "mode": "element",
      "subtitleSelector": "div.sc-ihgnxF",
      "tagName": "div"
    }
  ]
}

To use this config, paste it into the Custom Sites area (Options page > Audio tab) and click the blue "SAVE" button underneath it. Then, make sure to refresh the tab for the video site (if you have it open still) and it will load this new configuration.

If you do find an issue with it, please let me know what video and an approximate timestamp so I can make sure to get it fixed.

@richardfrost
Copy link
Collaborator

Sorry @Jenron3000, I did some more testing with that config I shared earlier and it definitely has some issues. This one should work much better:

{
  "www.discoveryplus.com": [
    {
      "apfCaptions": true,
      "apfCaptionsSelector": "div#overlay-root",
      "displaySelector": "div[data-testid=caption_renderer_overlay]",
      "mode": "watcher",
      "subtitleSelector": "div[data-testid=caption_renderer_overlay] div.sc-iMWBiJ div.sc-ihgnxF",
      "videoSelector": "div[data-testid=caption_renderer_overlay] video"
    }
  ]
}

@Jenron3000
Copy link
Author

Jenron3000 commented Apr 28, 2024

I tried dropping that code in and it still only blocks the caption and doesn't mute the audio. Should it change the code in the "supported sites config" list? after i save the code it doesn't change it.

@richardfrost
Copy link
Collaborator

Thanks for getting back to me @Jenron3000. Good question, but it won't change the "support sites config" in the list, those are just the built-in configs and are read-only.

I'm sorry, I just noticed both a typo and an error in the 2nd config I shared with you. Could you please try this one?

{
  "www.discoveryplus.com": [
    {
      "apfCaptions": true,
      "apfCaptionsSelector": "div#overlay-root",
      "displaySelector": "div[data-testid=caption_renderer_overlay]",
      "mode": "watcher",
      "subtitleSelector": "div[data-testid=caption_renderer_overlay] div.sc-iMWBiJ div.sc-ihgnxF",
      "videoSelector": "div[data-testid=video-container] video"
    }
  ]
}

Also, please make sure the site is set to normal (not Advanced or Deep).

If this one still doesn't work, can you share an example video so I can test it? Thanks!

@richardfrost
Copy link
Collaborator

@Jenron3000 When you get a chance let me know if this latest version works for you. Sorry again for the errors in the previous configs.

@Jenron3000
Copy link
Author

Jenron3000 commented May 6, 2024 via email

@richardfrost richardfrost self-assigned this May 6, 2024
@richardfrost
Copy link
Collaborator

Thanks for letting me know @Jenron3000.

This has been included in version 3.5.0 of the extension. For best results, make sure to remove any custom config used for testing like this once it has been included in the official update so you can automatically get future updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants