-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hulu audio muting not working #544
Comments
simply going to the page recreates it. |
It looks like at least in the case of the episode of "Life in Pieces" that they are using a new format for their captions. I don't have much time today, but here is a custom config that we could try on and I'd love to get some feedback from it: {
"www.hulu.com": [
{
"displaySelector": "div.ClosedCaption",
"iframe": false,
"mode": "watcher",
"note": "Hulu update 24-02",
"parentSelector": "div.ClosedCaption div.CaptionBox"
},
{
"className": "caption-text-box",
"displaySelector": "div.caption-text-box",
"mode": "element",
"subtitleSelector": "p",
"tagName": "DIV"
},
{
"displaySelector": "div.CaptionBox",
"mode": "elementChild",
"parentSelector": "div.CaptionBox",
"tagName": "P"
}
]
} To use this config, paste it into the Custom Sites area (Options page > Audio tab) and click the blue "SAVE" button underneath it. Then, make sure to refresh the tab for the video site (if you have it open still) and it will load this new configuration. Unfortunately with the way their subtitles appear to be working, at least on that episode I tried it looks like we'll have to fallback to the |
I did rough tests on both browsers and devices, and the custom config appeared to fix the problem. I'll keep the issue open for a few more days (in case I encounter more problems, or you find a more certain fix for it), but for now, it works great. Many thanks for your continued support! |
windows 11 chrome up to date seems to be working now. Looks like that was the fix. my number count is registering like about 3 filter actions for each 1. but it has been doing that on and off on several sites. Thanks heaps for the fix. |
Windows 11, Chrome and APF, all up to date. Tried different settings and nothing worked for me. Tubi, Max, Peacock and more work great but Hulu doesn't. Hope to see a fix soon. Thank you |
Hi thank you, new config I got to work. ty for your help |
Well after a few days of using Hulu, I can't say I've found any issues with the config, so I'll be closing the issue. Thanks again for your continued and quick support! |
Thank you for reporting back @bdc0der, @WolfD1g1tal, & @TruSteel. I'll get this added into the next version. For best results, make sure to remove any custom config used for testing like this once it has been included in the official update. |
This was added in Version 3.3.3. If you used the "Custom config" in this issue, its recommend to remove the custom config once it has been included in the official update. |
Duly noted, thank you |
🐛 Description
The extension recognizes text from captions on Hulu, but it doesn't mute the audio when the text gets censored.
🔀 Steps To Reproduce
✔️ Expected behavior
I expected the extension to censor the audio along with the text, but only the text censored
📷 Screenshots
💻 Details
📝 Additional context
Another user also reported this issue, so I tried to test the audio and edit this comment to make it easier for you.
The problem originally occurred on a custom APF config on Chrome, and I tried installing APF on a brand-new Firefox profile. I have also tried all audio muting methods but the problem persisted. With the browser tab method selected, it appears I can mute the browser tab manually, which suggests the extension failed to do so. Hopefully this makes sense.
(ignore the thing with only the UI being visible in the screenshot, it appears that Hulu not allowing me to capture video content)
The text was updated successfully, but these errors were encountered: