Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hulu on Disney+ Isn't Supported #531

Closed
richardfrost opened this issue Dec 30, 2023 · 2 comments
Closed

Hulu on Disney+ Isn't Supported #531

richardfrost opened this issue Dec 30, 2023 · 2 comments
Labels
Audio Bug Something isn't working
Milestone

Comments

@richardfrost
Copy link
Collaborator

🐛 Description

Hulu on Disney+ Isn't Supported

🔀 Steps To Reproduce

  1. Go to a Hulu (beta) title on Disney+
  2. Start a video
  3. Caption text isn't filtered unless Deep mode is enabled, and even then it doesn't mute.
@richardfrost richardfrost added Bug Something isn't working Audio labels Dec 30, 2023
@richardfrost richardfrost added this to the Audio milestone Dec 30, 2023
@richardfrost
Copy link
Collaborator Author

Adding support for Hulu isn't as straightforward as I had hoped. It will take some time to work around a couple issues to get it "just right". In the meantime, this custom config should get you most of the way there:

{
  "www.disneyplus.com": [
    {
      "displaySelector": "disney-web-player >>> div.dss-subtitle-renderer-wrapper div.dss-subtitle-renderer-cue-window",
      "mode": "watcher",
      "note": "Hulu",
      "subtitleSelector": "disney-web-player >>> div.dss-subtitle-renderer-wrapper span.dss-subtitle-renderer-line",
      "videoSelector": "disney-web-player >>> video"
    },
    {
      "className": "dss-subtitle-renderer-wrapper",
      "mode": "element",
      "subtitleSelector": "div.dss-subtitle-renderer-cue-window span.dss-subtitle-renderer-line",
      "tagName": "DIV"
    }
  ]
}

To use this config, paste it into the Custom Sites area (Options page > Audio tab) and click the blue "SAVE" button underneath it. Then, make sure to refresh the tab for the video site (if you have it open still) and it will load this new configuration.

Make sure you have the domain mode set to Normal (not Deep) for this to work.

Main Disney+ titles should continue to work like normal with this config, and Hulu titles should also mute, though there could be a very slight delay with muting/unmuting. In addition, hiding captions will likely be pretty choppy.

@richardfrost
Copy link
Collaborator Author

Disney+ has updated their site again, and the latest config can be found in issue #595. This should now be fixed with version 4.0.0. If anyone is still having issues, please respond in #595.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Audio Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant