Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: how long to mute when using auto-generated subtitles #121

Closed
qwertychouskie opened this issue Mar 13, 2019 · 5 comments
Closed
Labels
Enhancement New feature or request

Comments

@qwertychouskie
Copy link

Audio filtering ideally should have an option to configure how long a word is muted as it doesn't always quite mute the whole word.

BTW, thanks for such an awesome addon!

@richardfrost
Copy link
Collaborator

Thanks for the feedback. I'm glad you are enjoying the filter.

Are you thinking that each word should have an option to specify a mute time, or just a general rule for if a word is muted, the audio must be muted for at least the specified amount of time?

@qwertychouskie
Copy link
Author

The main thing I notice is that with youtube's auto-generated subs, the period the filtered word shows in the subtitles before the next word appears is sometimes like a couple milliseconds, meaning the filter only mutes for a couple milliseconds, which obviously won't do much good. :) Any way to work around this would be good.

@richardfrost
Copy link
Collaborator

Version 2.1.2 has been published and should be available soon with a feature to hopefully address this. You can find the setting in the at the bottom of the Audio options page. Let me know if it works for you, or if you have other suggestions to make it better.

@qwertychouskie
Copy link
Author

Thanks!

@richardfrost
Copy link
Collaborator

You're welcome! Fell free to comment here or open a new issue if its not working for you. Thanks again for the suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants