Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skew correction from Klipper implemented like #447

Open
roykrikke opened this issue Jan 31, 2024 · 2 comments
Open

Skew correction from Klipper implemented like #447

roykrikke opened this issue Jan 31, 2024 · 2 comments
Labels
enhancement New feature or request question Further information is requested stale Issue that appear to be inactive, mark for potenial closing if stale for longer time

Comments

@roykrikke
Copy link

Describe the feature or hardware support you'd like

Would be a great feature to add support for Skew correction inside klippain. E.g part of the macro START_PRINT.
https://www.klipper3d.org/Skew_Correction.html

To enable skew correction in the printer.cfg add [skew_correction]
It is needed to enter your skew numbers into the console and save it. This will save your skew profile to the bottom of printer.cfg.
E.g. SET_SKEW XY=141.22,141.15,100 XZ=140.87,141.34,99.84 YZ=141.12,141.26,99.94
SKEW_PROFILE SAVE=my_skew
Klipper docs warns about skew correction causing problems: https://www.klipper3d.org/Skew_Correction.html#caveats

I think it would be good to add SKEW_PROFILE LOAD to your START_PRINT macro and SET_SKEW CLEAR=1 to the END_PRINT macro. This could either be add to the klippain macros for Klipper or in the slicer program. Implementing this in klippain would be great. and a nice future in my opinion.

I'm curious what others think of this.

Additional context or information

No response

@roykrikke roykrikke added enhancement New feature or request triage This is a new issue to be sorted (automatic label) labels Jan 31, 2024
@Surion79
Copy link
Collaborator

the caveats i don't like that we can't control if the head is running outside the configured values as described.
how to handle skew profiles which are not set up? it feels like we being to debug other ppls skew settings, because they are not working as they would expect it. (wrong profile, profile not set correctly)
integration is no problem for someone who requires it. you can easily override a custom start_print module. there are three of them available for additional start_print actions.

@Surion79 Surion79 added question Further information is requested and removed triage This is a new issue to be sorted (automatic label) labels Jan 31, 2024
@Surion79 Surion79 added the stale Issue that appear to be inactive, mark for potenial closing if stale for longer time label Feb 22, 2024
@Zanonia
Copy link

Zanonia commented Jun 12, 2024

I don't understand how to use the custom start print module.
I have had this code in my overrides.cfg:

[gcode_macro _MODULE_CUSTOM1]
gcode:
    # Load skew profile
    SKEW_PROFILE LOAD=my_skew_profile 

But it doesn't seem to load something at print start...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested stale Issue that appear to be inactive, mark for potenial closing if stale for longer time
Projects
None yet
Development

No branches or pull requests

3 participants