Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Separate autoload and autoplay logic in player settings #6714

Closed
3 tasks done
Veeno opened this issue Feb 1, 2025 · 3 comments
Closed
3 tasks done

Comments

@Veeno
Copy link

Veeno commented Feb 1, 2025

Guidelines

  • I have searched the issue tracker for open and closed issues that are similar to the feature request I want to file, without success.
  • I have searched the documentation for information that matches the description of the feature request I want to file, without success.
  • This issue contains only one feature request.

Problem Description

This issue is very loosely related to #6670 . The relevance is primarily in ease of reasoning and communication, since "autoplay" and "automatically playing" is currently insufficient to differentiate between automatic loading of videos and automatic playing of videos. Disentangling the conflation of these two concepts should help both developers and users.

Specifically, the current relevant toggles in the player settings are as follows:

  • Autoplay Recommended Videos
  • Autoplay Playlist Videos
  • Start Videos Automatically

The first two toggles affect both loading and playing, whereas the third toggle affects only playing. It is also unclear which "videos" the third toggle refers to - does it only affect the automatic playing of manually loaded videos, or also of the videos loaded by one of the two "autoplay" mechanisms? (I.e., does the third toggle interact with the first two, or not?)

Proposed Solution

Replace the three toggles listed above with the following four toggles:

  • Autoload Recommended Videos
  • Autoload Playlist Videos
  • Play Autoloaded Videos Automatically
  • Play Manually Loaded Videos Automatically

This makes it clear both whether a toggle affects loading or playing, as well as which "videos" each autoplay toggle refers to. The concepts of loading and playing are separated from each other, which improves the clarity of the settings and the ability to reason about what exactly the effect of each toggle is (from both the developer and user perspective).

Alternatives Considered

None.

Issue Labels

display more information to user, ease of use improvement, improvement to existing feature

Additional Information

No response

@efb4f5ff-1298-471a-8973-3d47447115dc

Sorry but this is a wont implement. This is only being requested because stuff is broken rn. Otherwise it would be very clear what the toggles would do.

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc closed this as not planned Won't fix, can't repro, duplicate, stale Feb 1, 2025
@Veeno
Copy link
Author

Veeno commented Feb 1, 2025

This is only being requested because stuff is broken rn. Otherwise it would be very clear what the toggles would do.

This is a false assumption and a false statement, since the current brokenness of automatic playing has no bearing on the validity of the remarks regarding information clarity.

@absidue
Copy link
Member

absidue commented Feb 1, 2025

The suggested toggles would just increase the confusion and would be difficult to implement as there is functionally no difference in whether you manually clicked on a video or whether the two autoplay settings "clicked" on the next video for you. Internally everything happens the same after clicking on a video, so you are asking us to artificially introduce a difference where there currently isn't one.

As mentioned @efb4f5ff-1298-471a-8973-3d47447115dc above if things weren't currently broken you wouldn't be asking for things like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To assign
Development

No branches or pull requests

3 participants