Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Right clicking near the bottom of the video will add a scroll bar to the video #6006

Closed
6 tasks done
ChunkyProgrammer opened this issue Oct 29, 2024 · 1 comment · Fixed by #6075
Closed
6 tasks done
Labels
B: visual bug Something isn't working good first issue Good for newcomers

Comments

@ChunkyProgrammer
Copy link
Member

Guidelines

  • I have encountered this bug in the latest release of FreeTube.
  • I have encountered this bug in the official downloads of FreeTube.
  • I have searched the issue tracker for open and closed issues that are similar to the bug report I want to file, without success.
  • I have searched the documentation for information that matches the description of the bug I want to file, without success.
  • This issue contains only one bug.

Describe the bug

  1. go to a video
  2. right clear near the bottom of the video (below the progress bar/player buttons)
  3. Notice that there is a scroll bar and stats is below everything
    image

Expected Behavior

Any of these

  • don't display stats when an area that low is right clicked
  • force no scrollbar on the video

Issue Labels

visual bug

FreeTube Version

0.22.0

Operating System Version

Linux Mint 22

Installation Method

Flathub

Primary API used

Local API

Last Known Working FreeTube Version (If Any)

No response

Additional Information

No response

Nightly Build

@ChunkyProgrammer ChunkyProgrammer added the bug Something isn't working label Oct 29, 2024
@github-project-automation github-project-automation bot moved this to To assign in Bug Reports Oct 29, 2024
@ChunkyProgrammer ChunkyProgrammer added the good first issue Good for newcomers label Oct 29, 2024
@a0kami
Copy link
Contributor

a0kami commented Nov 2, 2024

Hey, I should probably have manifested myself before sending out the PR.
Interested in contributing on extra features but I figured I'd try something easy first.

I initially wanted to fix the context menu positioning by accounting for available space, i.e have the context menu moved a bit to the left or up if respectively too close to the right or bottom, and basically wanted to make sure to have something working first but hours and hours later, naively though I could got after the "contextmenu" event listener but I don't see no easy or clean way of achieving that.
Let me know how this looks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B: visual bug Something isn't working good first issue Good for newcomers
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants