Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Hardware video acceleration on Wayland #4621

Closed
3 tasks done
zestygrass opened this issue Jan 30, 2024 · 5 comments
Closed
3 tasks done

[Feature Request]: Hardware video acceleration on Wayland #4621

zestygrass opened this issue Jan 30, 2024 · 5 comments

Comments

@zestygrass
Copy link

Guidelines

  • I have searched the issue tracker for open and closed issues that are similar to the feature request I want to file, without success.
  • I have searched the documentation for information that matches the description of the feature request I want to file, without success.
  • This issue contains only one feature request.

Problem Description

Hardware video acceleration implementation introduced in #4532 for Linux is currently X-org only.

Proposed Solution

Hardware video acceleration on Linux should support Wayland. In the near future, Wayland will be the default display server protocol for Linux. This change should make Freetube ready for when more DE's default to Wayland.

Distro's such as Fedora have approved Wayland only session for their KDE Plasma spin in Fedora 40.
A similar issue was opened for Gnome in Fedora 40.

Alternatives Considered

N/A

Issue Labels

improvement to existing feature

Additional Information

No response

@efb4f5ff-1298-471a-8973-3d47447115dc

Not sure this is something we can solve as Electron also seems to have some issues electron/electron#36633

@Revival8697
Copy link

Revival8697 commented Jan 31, 2024

This will only be possible when updated to Electron 29 (Chromium 122), where this patch is merged.

@zestygrass
Copy link
Author

I suppose this would be possible once electron has official support, now we wait for stable release of electron 29 later this month.
Thanks for responding with appropriate information, it was helpful.

@efb4f5ff-1298-471a-8973-3d47447115dc

hi all could you try the latest nightly build and report back if this behavior is fixed. The latest nightly build contains Electron version v29.x.x!

@zestygrass
Copy link
Author

Tested it with nightly build 4044, hardware acceleration now works as intended on Wayland. Thank you so much.

I used the following flags if anyone else wants to try it.
--enable-features=WaylandWindowDecorations --ozone-platform-hint=auto --enable-features=VaapiVideoDecodeLinuxGL --gpu-context=wayland

Screenshot_20240307_144443

System information:

Operating System: Fedora Linux 39
KDE Plasma Version: 5.27.10
KDE Frameworks Version: 5.115.0
Qt Version: 5.15.12
Kernel Version: 6.7.7-200.fc39.x86_64 (64-bit)
Graphics Platform: Wayland
Processors: 16 × 12th Gen Intel® Core™ i5-1240P
Memory: 31.1 GiB of RAM
Graphics Processor: Mesa Intel® Graphics
Manufacturer: Framework
Product Name: Laptop (12th Gen Intel Core)
System Version: A4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants