Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Better error handling needed for unplayable content #3238

Closed
3 tasks done
efb4f5ff-1298-471a-8973-3d47447115dc opened this issue Mar 1, 2023 · 3 comments · Fixed by #5922
Closed
3 tasks done
Labels

Comments

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

efb4f5ff-1298-471a-8973-3d47447115dc commented Mar 1, 2023

Guidelines

  • I have searched the issue tracker for open and closed issues that are similar to the feature request I want to file, without success.
  • I have searched the documentation for information that matches the description of the feature request I want to file, without success.
  • This issue contains only one feature request.

Problem Description

We need to come up with a better way to inform the user that content is unplayable, instead of the current approach of displaying a completely broken page.

firefox_PoQr3wunCV.mp4

Proposed Solution

Something like YouTube's approach where we display everything that can be displayed and then replace the player with a message. This would apply to:

  • private videos
  • member only content
  • age-restricted videos
  • youtube movies that don't have a trailer
  • geo-restricted videos

Alternatives Considered

None.

Issue Labels

visual improvement

Additional Information

No response

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added the enhancement New feature or request label Mar 1, 2023
@absidue absidue changed the title [Feature Request]: Better error handle needed for member only content [Feature Request]: Better error handling needed for member only content Mar 2, 2023
@ChunkyProgrammer
Copy link
Member

Example video: https://www.youtube.com/watch?v=eJ-AaE9GnzQ

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc changed the title [Feature Request]: Better error handling needed for member only content [Feature Request]: Better error handling needed for unplayable content Jan 26, 2024
@aleksejrs
Copy link

It would be possible to add the videos to playlists and then watch them when they become available, when a proxy is enabled, or with a different means.

@pkrasicki
Copy link
Contributor

pkrasicki commented Oct 20, 2024

The case you described only includes situations when we know the video can't be played (because it's not supported). It doesn't include unexpected errors. I think both those cases should have a nice error page. The only difference would be that if we know the video isn't gonna work, we should display the error page immediately without making the user wait for the request to fail.

Edit:
I guess if we get an unexpected error, some data might be missing, so that's another difference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants