Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Livechat scrolling down doesn't hide arrow button #3158

Closed
5 tasks done
efb4f5ff-1298-471a-8973-3d47447115dc opened this issue Feb 6, 2023 · 11 comments · Fixed by #5302
Closed
5 tasks done
Labels
B: visual bug Something isn't working

Comments

@efb4f5ff-1298-471a-8973-3d47447115dc

Guidelines

  • I have encountered this bug in the latest release of FreeTube.
  • I have searched the issue tracker for open and closed issues that are similar to the bug report I want to file, without success.
  • I have searched the documentation for information that matches the description of the bug I want to file, without success.
  • This issue contains only one bug.

Describe the bug

  1. Go to any video with a live chat
  2. Scroll up in the chat
  3. Scroll down in the chat
  4. See that the blue button doesn't disappear and that u still have to scroll down to keep up with recent chats
FreeTube_vkwK4i2eOY.mp4

Expected Behavior

Button should go away and chat should automatically scroll down again. See YT chat for reference.

Issue Labels

visual bug

FreeTube Version

fa8cc07

Operating System Version

Windows 10 22H2

Installation Method

.exe

Primary API used

Local API

Last Known Working FreeTube Version (If Any)

No response

Additional Information

No response

Nightly Build

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added the bug Something isn't working label Feb 6, 2023
@predystopic-dev
Copy link
Contributor

Is this fixed already? I can't reproduce it in dev build

@github-actions
Copy link
Contributor

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member Author

Hi @predystopic-dev sorry for the delayed response. I can still replicate this on my end.

@github-actions
Copy link
Contributor

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions
Copy link
Contributor

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions
Copy link
Contributor

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions
Copy link
Contributor

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions
Copy link
Contributor

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@kommunarr
Copy link
Collaborator

I can specifically replicate this by pressing the scrollbar in the UI, but not by scrolling with my mouse.

@kommunarr
Copy link
Collaborator

kommunarr commented Jun 21, 2024

My analysis from re-discovering this myself:

This does not occur with slow scrolling down. It might have something to do with "momentum" of a faster scroll propelling it to the bottom that's not getting caught by the onscroll event handler (onScroll in watch-video-live-chat.js). I can tell that this is the likely issue because it's not happening when I put that handler logic in a setTimeout with a 100ms delay. That would technically work, but I would like to see if there's a less hacky fix.

@kommunarr kommunarr changed the title [Bug]: Livechat scrolling down doenst hide button [Bug]: Livechat scrolling down doesn't hide arrow button Jun 21, 2024
@FreeTubeApp FreeTubeApp deleted a comment from github-actions bot Jun 21, 2024
@FreeTubeApp FreeTubeApp deleted a comment from github-actions bot Jun 21, 2024
@FreeTubeApp FreeTubeApp deleted a comment from github-actions bot Jun 21, 2024
@FreeTubeApp FreeTubeApp deleted a comment from github-actions bot Jun 21, 2024
@FreeTubeApp FreeTubeApp deleted a comment from github-actions bot Jun 21, 2024
@FreeTubeApp FreeTubeApp deleted a comment from github-actions bot Jun 21, 2024
@FreeTubeApp FreeTubeApp deleted a comment from github-actions bot Jun 21, 2024
@FreeTubeApp FreeTubeApp deleted a comment from github-actions bot Jun 21, 2024
@FreeTubeApp FreeTubeApp deleted a comment from github-actions bot Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B: visual bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants