Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing this field and moving all languages into the receiver logic #835

Merged
merged 21 commits into from
Jul 20, 2022

Conversation

oxisto
Copy link
Member

@oxisto oxisto commented Jun 15, 2022

This PR changes all language frontends into the receiver logic, instead of creating a this field. The receiver field of a MethodDeclaration contains a more detailed explanation, especially for frontend developers how to create it.

One notable exception is the usage of inner classes in Java. In this case, a this referring to the outer class is created, e.g. OuterClass.this. This is similar to what the Java compiler does in the byte code.

@oxisto oxisto changed the title getting rid of this field Removing this field and moving all languages into the receiver logic Jun 15, 2022
@oxisto oxisto force-pushed the getting-rid-of-this-field branch from 620e616 to 48fe2ca Compare June 19, 2022 20:04
@oxisto oxisto added this to the 5.0 milestone Jun 26, 2022
@oxisto oxisto marked this pull request as ready for review June 26, 2022 19:43
@oxisto oxisto requested a review from konradweiss as a code owner June 26, 2022 19:43
@oxisto oxisto requested a review from peckto as a code owner July 12, 2022 05:07
@oxisto oxisto force-pushed the getting-rid-of-this-field branch from 14b1b47 to b04a240 Compare July 12, 2022 05:10
@oxisto oxisto force-pushed the getting-rid-of-this-field branch from b04a240 to 8cd4f72 Compare July 12, 2022 07:13
@oxisto oxisto enabled auto-merge (squash) July 20, 2022 15:53
@sonarcloud
Copy link

sonarcloud bot commented Jul 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

90.3% 90.3% Coverage
0.0% 0.0% Duplication

@oxisto oxisto merged commit daac296 into main Jul 20, 2022
@oxisto oxisto deleted the getting-rid-of-this-field branch July 20, 2022 16:06
@KuechA KuechA mentioned this pull request Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants