Performance tests and improvements: LLVM and Type updates #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
KuechA
commented
May 11, 2022
KuechA
commented
- Test the performance of larger LLVM files
- Improve performance when handling phi: Use SubgraphWalker less frequently
- Improve performance of type updates: Use lists instead of sets
|
Kudos, SonarCloud Quality Gate passed! |
oxisto
approved these changes
Jun 15, 2022
oxisto
reviewed
Jun 15, 2022
| return typeCache; | ||
| } | ||
|
|
||
| public synchronized void cacheType(HasType node, Type type) { | ||
| if (!isUnknown(type)) { | ||
| typeCache.computeIfAbsent(node, n -> new HashSet<>()).add(type); | ||
| List<Type> types = typeCache.computeIfAbsent(node, n -> new ArrayList<>()); | ||
| if (!types.contains(type)) { |
There was a problem hiding this comment.
Isn't this essentially the same as a set does? Not sure this is really faster / better here.
| @@ -131,7 +131,7 @@ public void setModifiers(List<String> modifiers) { | |||
| } | |||
|
|
|||
| @Override | |||
| public void typeChanged(HasType src, Collection<HasType> root, Type oldType) { | |||
| public void typeChanged(HasType src, List<HasType> root, Type oldType) { | |||
There was a problem hiding this comment.
Would it be possible to keep Collection in the function signature here?
| @@ -83,7 +83,7 @@ public Type getPropagationType() { | |||
| } | |||
|
|
|||
| @Override | |||
| public void setType(Type type, Collection<HasType> root) { | |||
| public void setType(Type type, List<HasType> root) { | |||
There was a problem hiding this comment.
Same here. Keep signature and only change the implememation?
| @@ -165,12 +165,11 @@ public void typeChanged(HasType src, Collection<HasType> root, Type oldType) { | |||
| } | |||
|
|
|||
| @Override | |||
| public void possibleSubTypesChanged( | |||
| HasType src, Collection<HasType> root, Set<Type> oldSubTypes) { | |||
| public void possibleSubTypesChanged(HasType src, List<HasType> root) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.