-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major overhaul of the python language frontend #513
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces the singelton with a standard class and cleans up temporary files after use.
This reverts commit cd9b082.
oxisto
approved these changes
Oct 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to extract more of the if/elif constructs into individual handle_XXX
functions, but let's keep that for the second round of refactoring. Let's merge it as experimental in order to progress.
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP PR. The aim is to rewrite the python frontend to use a similar approach as the other frontends (
handle_statement
/handle_expresssion
/ ... instead of recursively traversing the AST). The old approach made some changes quiet difficult to implement.TODOs before this can be merged:
handle_xxx()
functionsn elegantsolution to build and install the python packageHow to try out this PR on your system:
Just make sure to have JEP installed (currently version 4.0.0). If you tried out an old version of this PR before and have the "CPGPython" package locally installed -> remove it.