Adds StatementHolder interface and ability to model statements in structure declarations
#468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…claration Some languages allow to write executable code on file, class or even namespace level, e.g. javas static and initializer blocks or any code outside of functions in scripting languages. This commit extracts the statement management from the CompoundStatement into default implementations of the CodeHolder interface and implements it in RecordDeclaration, NamespaceDeclaration and TranslationUnitDeclaration. Additionally the EOG-Pass is adapted to also build EOG-Paths over those code blocks.
oxisto
reviewed
Jul 13, 2021
cpg-library/src/main/java/de/fraunhofer/aisec/cpg/graph/CodeHolder.java
Outdated
Show resolved
Hide resolved
cpg-library/src/main/java/de/fraunhofer/aisec/cpg/graph/CodeHolder.java
Outdated
Show resolved
Hide resolved
cpg-library/src/main/java/de/fraunhofer/aisec/cpg/graph/CodeHolder.java
Outdated
Show resolved
Hide resolved
cpg-library/src/main/java/de/fraunhofer/aisec/cpg/graph/CodeHolder.java
Outdated
Show resolved
Hide resolved
cpg-library/src/main/java/de/fraunhofer/aisec/cpg/graph/CodeHolder.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| @NonNull | ||
| default List<PropertyEdge<Statement>> getStatementsPropertyEdge() { |
There was a problem hiding this comment.
What’s the point of this additional getter?
oxisto
changed the title
StatementHolder interface and ability to model statements in structure declarations
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some languages allow to write executable code on file, class or even namespace level,
e.g. javas static and initializer blocks or any code outside of functions in scripting
languages.
This commit extracts the statement management from the CompoundStatement into default
implementations of the CodeHolder interface and implements it in RecordDeclaration,
NamespaceDeclaration and TranslationUnitDeclaration.
Additionally the EOG-Pass is adapted to also build EOG-Paths over those code blocks.
Closes #464