Execute TypeResolver before VariableUsageResolver
#1277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxisto
force-pushed
the
move-type-resolver
branch
6 times, most recently
from
478cd01
to
e67b5cb
Compare
oxisto
force-pushed
the
move-type-resolver
branch
from
e67b5cb
to
23382e9
Compare
oxisto
commented
Aug 11, 2023
cpg-core/src/main/kotlin/de/fraunhofer/aisec/cpg/TypeManager.kt
Outdated
Show resolved
Hide resolved
oxisto
force-pushed
the
move-type-resolver
branch
2 times, most recently
from
ada673a
to
050abd0
Compare
This PR moves the execution order of the `TypeResolver` before the `VariableUsageResolver` and `CallResolver`. This should help clean up the type manager code that deals with record / type hierachies in a better way.
oxisto
force-pushed
the
move-type-resolver
branch
from
050abd0
to
ba9d323
Compare
KuechA
reviewed
Aug 11, 2023
cpg-core/src/main/kotlin/de/fraunhofer/aisec/cpg/graph/types/WrapState.kt
Outdated
Show resolved
Hide resolved
cpg-core/src/main/kotlin/de/fraunhofer/aisec/cpg/graph/types/WrapState.kt
Show resolved
Hide resolved
cpg-core/src/main/kotlin/de/fraunhofer/aisec/cpg/passes/TypeResolver.kt
Outdated
Show resolved
Hide resolved
…rapState.kt Co-authored-by: KuechA <31155350+KuechA@users.noreply.github.com>
|
Kudos, SonarCloud Quality Gate passed! |
KuechA
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the execution order of the
TypeResolverbefore theVariableUsageResolverandCallResolver. This should help clean up the type manager code that deals with record / type hierachies in a better way.