Convert Neo4j pre-save hooks to cpg pass

[peckto]

In preparation for #1215

[oxisto]

Looks good. Maybe just a quick discussion: Should we have this pass in cog-core or in cpg-neo4j?

[oxisto]

Ok it seems are test design for neo4j is really ... crap. We are setting up our own translation result here in the test instead of re-using the function that exists in the Application:

cpg/cpg-neo4j/src/test/kotlin/de/fraunhofer/aisec/cpg_vis_neo4j/ApplicationTest.kt

Lines 47 to 62 in 182b9ec

	fun testPush() {
	val topLevel = Paths.get("src").resolve("test").resolve("resources").toAbsolutePath()
	val path = topLevel.resolve("client.cpp").toAbsolutePath()
	val file = File(path.toString())
	assert(file.exists() && !file.isDirectory && !file.isHidden)
	val translationConfiguration =
	TranslationConfiguration.builder()
	.sourceLocations(file)
	.topLevel(topLevel.toFile())
	.defaultPasses()
	.defaultLanguages()
	.debugParser(true)
	.build()
	val translationManager =
	TranslationManager.builder().config(translationConfiguration).build()
	translationResult = translationManager.analyze().get()

@peckto Can you maybe merge this as part of this PR so that the test is actually using the prepared TR of the application?

[peckto]

I reworked the ApplicationTest to use the setupTranslationConfiguration, including the arg parse interface.

[peckto]

Looks good. Maybe just a quick discussion: Should we have this pass in cog-core or in cpg-neo4j?

I don't have a strong opinion on this.
Maybe the pass is (in future) also helpful for other serialization methods?
We could also rename the pass to something more generic like PrepareSerialization or similar.

[peckto]

The pass is executed before FilenameMapper, as FilenameMapper is last, this will be second last.

[oxisto]

Looks good. Maybe just a quick discussion: Should we have this pass in cog-core or in cpg-neo4j?

I don't have a strong opinion on this. Maybe the pass is (in future) also helpful for other serialization methods? We could also rename the pass to something more generic like PrepareSerialization or similar.

Renaming it to PrepareSerialization would be a good idea.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

88.9% Coverage
0.0% Duplication