Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconfigure version range for vscode #343

Merged
merged 2 commits into from
Nov 17, 2021
Merged

Conversation

fwendland
Copy link
Collaborator

@fwendland fwendland commented Nov 10, 2021

Set engine and @types/vscode back to version range. Both are set to the same range value.

This should improve usability of Codyze VSCode plugin as exact version matches are removed. The exact version causes problems when VSCode releases outpace the version demanded by the plugin. This has prevented the installation of the plugin in newer VSCode instances.

Set engine and @types/vscode back to version range. Both are set
to the same range value.

This should improve usability of Codyze VSCode plugin as exact
version matches are removed. The exact version causes problems
when VSCode releases outpace the version demanded by the plugin.
This has prevented the installation of the plugin in newer
VSCode instances.
@fwendland fwendland added enhancement New feature or request dependencies Pull requests that update a dependency file labels Nov 10, 2021
@fwendland fwendland added this to the 2.0.0 milestone Nov 10, 2021
@fwendland fwendland self-assigned this Nov 10, 2021
@sonarcloud
Copy link

sonarcloud bot commented Nov 15, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@fwendland
Copy link
Collaborator Author

Changed my mind. Let's merge it for now and see what renovate will do.

@fwendland fwendland marked this pull request as ready for review November 17, 2021 14:03
@fwendland fwendland merged commit e7f79cc into main Nov 17, 2021
@fwendland fwendland deleted the fw/vscode-version-range branch November 17, 2021 14:03
fwendland added a commit that referenced this pull request Apr 15, 2024
Set engine and @types/vscode back to version range. Both are set
to the same range value.

This should improve usability of Codyze VSCode plugin as exact
version matches are removed. The exact version causes problems
when VSCode releases outpace the version demanded by the plugin.
This has prevented the installation of the plugin in newer
VSCode instances.

Co-authored-by: Christian Banse <christian.banse@aisec.fraunhofer.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants