Fix loading multiple mark files #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation iterated over the specified MARK files and loaded them. However, it was overseen that each load would created a new XtextParser. Thereby, previously loaded entities were no longer available causing error while parsing MARK. This fix now passes along the array of MARK file locations to the load method. It creates one parser and adds all specified and discovered files to this single instance.
|
SonarCloud Quality Gate failed. |
fwendland
added a commit
that referenced
this pull request
Apr 15, 2024
The implementation iterated over the specified MARK files and loaded them. However, it was overseen that each load would created a new XtextParser. Thereby, previously loaded entities were no longer available causing error while parsing MARK. This fix now passes along the array of MARK file locations to the load method. It creates one parser and adds all specified and discovered files to this single instance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation iterated over the specified MARK files and loaded them. However,
it was overseen that each load would created a new XtextParser. Thereby, previously
loaded entities were no longer available causing error while parsing MARK.
This fix now passes along the array of MARK file locations to the load method. It
creates one parser and adds all specified and discovered files to this single
instance.