Replacing OverflowDB with CPG in-memory Graph #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the start of the removal of OverflowDB. I will do this gradually and trying not to brake too many things at once. The first step is to move the Evaluator into a LegacyEvaluator and start with a new Evaluator class. This is slightly blocked with support for CPG 4.0 (see #184), because otherwise we cannot add new features to the CPG graph if we need them. Closes #218
oxisto
force-pushed
the
remove-overflow-db
branch
from
69fac13
to
b26e501
Compare
|
The first test in |
|
The initial pass is done. @fwendland how should we proceed? Directly remove all the legacy files? I really do not want to keep them too long, they were primarily my reference in building the new evaluator. |
Builtin `_now()` returns the current time at execution as seconds since epoch -- 1970-01-01T00:00:00Z. Builtin `_year()` takes an integer argument, interprets it as seconds since epoch and returns the current year. `_now()` and `_year()` can be used in conjunction to create time dependent rules. For instance, one can write rules that are valid for a predetermined number of years. Afterwards, these rules are considered obsolete. To implement zero parameter builtins, `Builtin` was retrofitted with a flag to indicate whether it has parameters.
Merged
fwendland
reviewed
Jul 13, 2021
src/main/java/de/fraunhofer/aisec/analysis/markevaluation/OrderNFAEvaluator.java
Outdated
Show resolved
Hide resolved
src/main/java/de/fraunhofer/aisec/analysis/markevaluation/Evaluator.java
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed! |
fwendland
added a commit
that referenced
this pull request
Apr 15, 2024
Co-authored-by: Wendland, Florian <florian.wendland@aisec.fraunhofer.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes OverflowDB and Gremlin. This is slightly blocked with support for CPG 4.0 (see #184), because otherwise we cannot add new features to the CPG graph, should we need them. That is why this is currently based on a specific CPG commit (using JitPack) that already has the following PRs merged in:
definedBeforeinCallResolvercpg#458Node::idtovarcpg#459HasInitializerinterface for fields and variable declarations cpg#460This PR deprecates the CLI Jython-based console, because it was unmaintained for a while and the
cpg-consoleof thecpgproject might be a good replacement for it; or rather we could extend thecpg-console, but I want to keep this as a separate PR.Closes #218
Blocked by: