Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Add support for structured addresses #30

Open
5 tasks done
mnvfs opened this issue Jan 21, 2024 · 2 comments · May be fixed by #57
Open
5 tasks done

[Feature request] Add support for structured addresses #30

mnvfs opened this issue Jan 21, 2024 · 2 comments · May be fixed by #57
Labels
feature request Issue is about a new feature in the app

Comments

@mnvfs
Copy link

mnvfs commented Jan 21, 2024

Checklist

  • I made sure that there are no existing issues - open or closed - to which I could contribute my information.
  • I have read the FAQ and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.

Is your feature request related to a problem? Please describe.
At the moment there is only a single field for addresses. Therefore addresses are not synced correctly when also syncing with other clients like Thunderbird which have structured address field support.

Describe the solution you'd like
Add individual fields for the different address parts. Could be done as an option to support simple mode also for people who preferre this.

Describe alternatives you've considered
The different fields could be merged into one during sync. This would not improve editing behavior.

Additional context
This fork of Simple Contacts already contains structured address fields and I think the author would be willing to contribute.
https://github.com/stephanritscher/Simple-Contacts

@mnvfs mnvfs added feature request Issue is about a new feature in the app needs triage Issue is not yet ready for PR authors to take up labels Jan 21, 2024
@mnvfs mnvfs changed the title Add support for structured addresses [Feature request] Add support for structured addresses Jan 21, 2024
@Aga-C Aga-C removed the needs triage Issue is not yet ready for PR authors to take up label Jan 21, 2024
@Netpilgrim
Copy link

Netpilgrim commented Jan 22, 2024

It would be great if @stephanritscher's patches could be merged into Fossify Contacts. I’ve been using his fork for a while and it works very well. Not only does it implement the correct address separation the vCard standard requires, it also provides country-specific formatting of the whole address on the contact info screen. (I can only attest the latter for German addresses where the postal code is shown correctly before the locality, whereas most apps just format every address according to US rules.) [Edit: I should have checked this first; apparently the app shows the postal code before the locality independent of the country of the address. I’ll have to investigate further if that is somehow specific to my phone's setup.]

Right now Fossify Contacts, same as the main-line Simple Contacts before it, stores the complete address in the street address field, which is just wrong; so I wouldn’t even consider this a feature request but a bug ticket.

Update: Since I’ve made the mistake of assuming the formatting feature mentioned above, I’ve made a corresponding feature request at stephanritscher/Simple-Contacts#18. Should proper address handling find its way into Fossify Contacts, the same would be nice to have here as well.

@Netpilgrim
Copy link

For context, here is the original Simple Contacts discussion of this issue:
SimpleMobileTools/Simple-Contacts#364

Apparently the developer @tibbi thought making the address format standards-compliant was too much of a “complication.”

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is about a new feature in the app
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants