-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pubsub: fix config settings #39
Conversation
I haven't had time to dig in too deeply. Will this cause the amount of data stored locally to bloat? What does the |
For this specific issue, the random name is used to From what I've learned, repos (the name we are giving it) is how they identify nodes in the network and data can be shared between them. At some point I think we should name the repo using the user information (and maybe some device information too).
This warning is important. I am not sure of the full implications or randomly naming repos with each refresh but I'll keep researching. Reference: https://github.com/ipfs/specs/tree/master/repo#notes |
It looks like every page refresh will duplicate all of our IPFS data. Note especially that |
I tried looking into this briefly. I'm feeling too dumb to make sense of it at the moment. Sorry I couldn't offer anything more constructive than "this doesn't seem quite right"! |
Ok. I removed the cache busting (I suppose a Added I notice the GIFs take less time to render, maybe the IPFS network received an update :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm uncertain why we need this, as an IPFS team member says that the bug was fixed. But this doesn't seem problematic, outside of introducing possibly-superfluous code. If you think we do, in fact, need this code, then I'll trust you on it.
As referenced here: ipfs/js-ipfs#1029 (comment)
This PR adds a random name to the IPFS repo name and set config params for a change in the
mutliaddr
dependency.