Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External module imports #136

Closed
nichollsh opened this issue Aug 9, 2024 · 2 comments · Fixed by #138
Closed

External module imports #136

nichollsh opened this issue Aug 9, 2024 · 2 comments · Fixed by #138
Assignees
Labels
bug Something isn't working

Comments

@nichollsh
Copy link
Contributor

The code currently as utils.modules_ext.py to import external modules such as Numpy, Scipy, Matplotlib, etc. This means that modules are sometimes imported when not required, and also makes code linting very tricky.

Instead, modules should be imported within the files in which they are used.

@nichollsh nichollsh added the bug Something isn't working label Aug 9, 2024
@nichollsh nichollsh changed the title External modules External module imports Aug 9, 2024
@nichollsh
Copy link
Contributor Author

@stefsmeets I think this is connected with your Issue #131 and the code structure reorganisation into the usual package format?

@lsoucasse
Copy link
Member

Yes! we discussed it yesterday with Stef.

@stefsmeets stefsmeets self-assigned this Aug 9, 2024
@stefsmeets stefsmeets mentioned this issue Aug 12, 2024
2 tasks
@github-project-automation github-project-automation bot moved this from Next up to Done in PROTEUS Development Roadmap Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants