This repository was archived by the owner on Jun 14, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 105
fix(command generate): fix generation of project with postgres on node 14.4 #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveBunlon
suggested changes
Jul 1, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment above
I tried with node 14.4 and it is working fine 🤔. Let me try with 14.5 |
It worked fine on mongodb (The warning was about mongo), it was it seems just a warning. I upgraded mongo and the warning disappeared 😉 |
It has nothing to do with mongodb. I tested it again and it works, I must have missed my first test. You can remove the Mongodb fix if you wanna strictly stick to the PR name |
SteveBunlon
approved these changes
Jul 6, 2020
33e2458
to
ad2f456
Compare
forest-bot
added a commit
that referenced
this pull request
Jul 7, 2020
## [3.6.1](v3.6.0...v3.6.1) (2020-07-07) ### Bug Fixes * **command generate:** fix generation of project with postgres on node 14.4 ([#446](#446)) ([9a307b3](9a307b3))
🎉 This PR is included in version 3.6.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist: