Skip to content
This repository was archived by the owner on Jun 14, 2024. It is now read-only.

fix(command generate): fix generation of project with postgres on node 14.4 #446

Merged
merged 1 commit into from
Jul 7, 2020

Conversation

VincentMolinie
Copy link
Member

Pull Request checklist:

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Create automatic tests
  • No automatic tests failures
  • Test manually the implemented changes
  • Review my own code (indentation, syntax, style, simplicity, readability)
  • Wonder if you can improve the existing code

@VincentMolinie
Copy link
Member Author

@SteveBunlon
Copy link
Member

Screenshot 2020-07-01 at 18 19 16

This is what I've got using node version 14.5.0. We must have another issue elsewhere.

Can you confirm an install work on your machine using node > 14 ?

Copy link
Member

@SteveBunlon SteveBunlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above

@VincentMolinie
Copy link
Member Author

st have another

I tried with node 14.4 and it is working fine 🤔. Let me try with 14.5

@VincentMolinie
Copy link
Member Author

It worked fine on mongodb (The warning was about mongo), it was it seems just a warning. I upgraded mongo and the warning disappeared 😉

@SteveBunlon
Copy link
Member

It has nothing to do with mongodb. I tested it again and it works, I must have missed my first test.

You can remove the Mongodb fix if you wanna strictly stick to the PR name

@VincentMolinie VincentMolinie merged commit 9a307b3 into master Jul 7, 2020
@VincentMolinie VincentMolinie deleted the fix/pg-node-14.4 branch July 7, 2020 12:47
forest-bot added a commit that referenced this pull request Jul 7, 2020
## [3.6.1](v3.6.0...v3.6.1) (2020-07-07)

### Bug Fixes

* **command generate:** fix generation of project with postgres on node 14.4 ([#446](#446)) ([9a307b3](9a307b3))
@forest-bot
Copy link
Member

🎉 This PR is included in version 3.6.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@SteveBunlon SteveBunlon linked an issue Jul 8, 2020 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stuck Connection to database
3 participants